Fix 404 on disabling cards in Phortune
AbandonedPublic
Actions

Authored by chad on Jan 8 2016, 4:57 PM.

Details

Reviewers

Summary

This fixes the 404, which was calling an incorrect ID. Though I think people would prefer to delete sensitive data like credit cards.

Test Plan

Disable free money, see free money disabled.

Diff Detail

Repository

rP Phabricator

Branch

phortune-disable (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9994
Build 12081: Run Core Tests
Build 12080: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36166.Jan 8 2016, 4:57 PM

chad retitled this revision from to Fix 404 on disabling cards in Phortune.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 8 2016, 4:57 PM

Oh, didn't catch this before I saw the other mail. rP7ba13edc2ef96d9e2bc4f969c011dd4ee7c2d6e1 is the same fix.

(We could call this "Delete" in the UI, but we need to keep the record around to be able to show that, e.g., you paid January on card A and February on card B or whatever.)

ah true, we dont store the card itself.

chad abandoned this revision.Jan 8 2016, 5:14 PM

Yeah. The copy could be a little more reassuring, perhaps, e.g.:

"Remove" instead of "Disable".
Don't show by default.
Add "All Methods" button, maybe only for merchants, to review removed methods if you need to audit things ("Can you give me a list of every charge you made against card A?").

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

controller/

PhortunePaymentMethodDisableController.php

2 lines

Diff 36166

View Options

src/applications/phortune/controller/PhortunePaymentMethodDisableController.php

Fix 404 on disabling cards in PhortuneAbandonedPublicActions