Page MenuHomePhabricator

Fix cpplint message regex
ClosedPublic

Authored by jra3 on Jan 6 2016, 5:59 PM.

Details

Summary

ref T8404

The issue is caused, not by the non-zero return code, but by the fact that
$messages is coming back empty due to the incorrect regex. tyhoff pointed out
that the regex matched correctly when we used STDIN, but now it is failing.

https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/ArcanistExternalLinter.php;8c589f1f759f0913135b8cc6959a6c1589e14ae4$357

Test Plan

arc lint cpp file containing lint error. run cpplint on the
file directly to confirm that there are errors and that the return code
is non-zero

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jra3 retitled this revision from to Fix cpplint message regex.
jra3 updated this object.
jra3 edited the test plan for this revision. (Show Details)
jra3 added reviewers: Blessed Reviewers, epriestley.

The bug linked to in the summary should provide the context needed.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 9:14 PM
This revision was automatically updated to reflect the committed changes.