Page MenuHomePhabricator

Implement a dedicated "diffusion.blame" API method
ClosedPublic

Authored by epriestley on Jan 6 2016, 1:17 PM.
Tags
None
Referenced Files
F15455800: D14957.diff
Sun, Mar 30, 4:55 AM
F15449669: D14957.id36139.diff
Fri, Mar 28, 11:34 AM
F15447642: D14957.id.diff
Fri, Mar 28, 12:44 AM
F15446276: D14957.id36136.diff
Thu, Mar 27, 6:08 PM
F15442390: D14957.diff
Wed, Mar 26, 11:07 PM
F15441524: D14957.id.diff
Wed, Mar 26, 6:36 PM
F15417806: D14957.id36139.diff
Thu, Mar 20, 6:44 PM
F15385528: D14957.id.diff
Fri, Mar 14, 10:47 PM
Subscribers
None

Details

Summary

Fixes T2451. Several motivations here, from strongest to weakest:

  • Currently, getting blame and file content are closely entwined. This makes fixing T9319 more difficult, and I want to fix it. I want to separate blame from content so there's more flexibility in how we approach this issue.
  • This makes pursuing T2450 easier, if it turns out to be a meaningful win.
  • If we can get a win on blame performance, we can do arc blame eventually if we want.
Test Plan
  • Blamed in SVN, Git and Mercurial.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a dedicated "diffusion.blame" API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.