Page MenuHomePhabricator

Implement a dedicated "diffusion.blame" API method
ClosedPublic

Authored by epriestley on Jan 6 2016, 1:17 PM.
Tags
None
Referenced Files
F15552609: D14957.id.diff
Sun, Apr 27, 9:40 PM
F15551370: D14957.id36136.diff
Sun, Apr 27, 4:39 PM
F15547989: D14957.diff
Sat, Apr 26, 9:02 PM
F15544143: D14957.diff
Sat, Apr 26, 3:07 AM
F15524706: D14957.diff
Mon, Apr 21, 9:51 AM
F15516895: D14957.id36136.diff
Fri, Apr 18, 10:02 PM
F15474874: D14957.diff
Sun, Apr 6, 1:04 PM
F15474334: D14957.id36136.diff
Sun, Apr 6, 7:28 AM
Subscribers
None

Details

Summary

Fixes T2451. Several motivations here, from strongest to weakest:

  • Currently, getting blame and file content are closely entwined. This makes fixing T9319 more difficult, and I want to fix it. I want to separate blame from content so there's more flexibility in how we approach this issue.
  • This makes pursuing T2450 easier, if it turns out to be a meaningful win.
  • If we can get a win on blame performance, we can do arc blame eventually if we want.
Test Plan
  • Blamed in SVN, Git and Mercurial.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a dedicated "diffusion.blame" API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.