Page MenuHomePhabricator

Implement a dedicated "diffusion.blame" API method
ClosedPublic

Authored by epriestley on Jan 6 2016, 1:17 PM.
Tags
None
Referenced Files
F19064398: D14957.id.diff
Nov 29 2025, 9:14 PM
F18995161: D14957.diff
Nov 19 2025, 3:58 PM
F18927707: D14957.diff
Nov 9 2025, 9:16 PM
F18820565: D14957.id36139.diff
Oct 22 2025, 3:58 PM
F18771836: D14957.id.diff
Oct 8 2025, 10:16 PM
F18767282: D14957.diff
Oct 7 2025, 9:44 PM
F18766554: D14957.id36136.diff
Oct 7 2025, 5:18 PM
F18738154: D14957.diff
Oct 1 2025, 2:21 PM
Subscribers
None

Details

Summary

Fixes T2451. Several motivations here, from strongest to weakest:

  • Currently, getting blame and file content are closely entwined. This makes fixing T9319 more difficult, and I want to fix it. I want to separate blame from content so there's more flexibility in how we approach this issue.
  • This makes pursuing T2450 easier, if it turns out to be a meaningful win.
  • If we can get a win on blame performance, we can do arc blame eventually if we want.
Test Plan
  • Blamed in SVN, Git and Mercurial.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a dedicated "diffusion.blame" API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.