Page MenuHomePhabricator

Implement a dedicated "diffusion.blame" API method
ClosedPublic

Authored by epriestley on Jan 6 2016, 1:17 PM.
Tags
None
Referenced Files
F18085596: D14957.diff
Tue, Aug 5, 7:19 PM
F18038248: D14957.id36136.diff
Sun, Aug 3, 2:54 AM
F17916387: D14957.diff
Tue, Jul 29, 10:05 PM
Unknown Object (File)
May 30 2025, 10:34 AM
Unknown Object (File)
May 29 2025, 3:44 PM
Unknown Object (File)
May 27 2025, 9:58 PM
Unknown Object (File)
May 10 2025, 4:17 AM
Unknown Object (File)
May 10 2025, 4:17 AM
Subscribers
None

Details

Summary

Fixes T2451. Several motivations here, from strongest to weakest:

  • Currently, getting blame and file content are closely entwined. This makes fixing T9319 more difficult, and I want to fix it. I want to separate blame from content so there's more flexibility in how we approach this issue.
  • This makes pursuing T2450 easier, if it turns out to be a meaningful win.
  • If we can get a win on blame performance, we can do arc blame eventually if we want.
Test Plan
  • Blamed in SVN, Git and Mercurial.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a dedicated "diffusion.blame" API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.