Page MenuHomePhabricator
Differential D14906

Fix an excessively aggressive transaction check in Owners
ClosedPublic
Actions

Authored by epriestley on Dec 28 2015, 9:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 1:01 AM
Unknown Object (File)
Tue, Dec 3, 7:16 AM
Unknown Object (File)
Mon, Dec 2, 6:05 PM
Unknown Object (File)
Tue, Nov 26, 8:42 PM
Unknown Object (File)
Sun, Nov 24, 4:00 PM
Unknown Object (File)
Sun, Nov 24, 6:30 AM
Unknown Object (File)
Sat, Nov 23, 3:43 AM
Unknown Object (File)
Thu, Nov 21, 11:04 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10058: Cannot Archive Owners Package
Commits
Restricted Diffusion Commit
rP1443e4b13dd4: Fix an excessively aggressive transaction check in Owners
Summary

Fixes T10058. We don't need to continue on this check if no path changes are being applied.

Test Plan

Archived an owners package.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36026.Dec 28 2015, 9:30 PM
epriestley retitled this revision from to Fix an excessively aggressive transaction check in Owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10058: Cannot Archive Owners Package.
chad accepted this revision.Dec 28 2015, 9:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2015, 9:42 PM
Closed by commit rP1443e4b13dd4: Fix an excessively aggressive transaction check in Owners (authored by epriestley, committed by epriestley). · Explain WhyDec 28 2015, 10:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
editor/
4 lines

Diff 36027

View Options

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

Loading...
Phabricator · Built by Phacility