Page MenuHomePhabricator

Move "Lock Project" to a separate action
ClosedPublic

Authored by epriestley on Dec 27 2015, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 16, 7:03 AM
Unknown Object (File)
Thu, Nov 10, 9:47 AM
Unknown Object (File)
Thu, Nov 10, 3:01 AM
Unknown Object (File)
Thu, Nov 10, 3:01 AM
Unknown Object (File)
Thu, Nov 10, 3:01 AM
Unknown Object (File)
Thu, Nov 10, 1:24 AM
Unknown Object (File)
Tue, Nov 8, 4:49 AM
Unknown Object (File)
Oct 28 2022, 2:01 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rPe8ddfad6dbd2: Move "Lock Project" to a separate action
Summary

Ref T10010. Three motivations:

  • Primarily: this makes conversion to EditEngine easier since I don't have to convert this weird control.
  • This probably needs to have "Lock", "Unlock" and "Use Parent Project Setting" values after subprojects? But maybe just locking any parent locks all the children? Anyway, doesn't make sense to put it on the main edit form if it's weird like this, I think, since we'll want some kind of explanatory text.
  • I probably want to move this to the "Members" tab anyway, and this won't be available on milestone projects at all.
Test Plan

Locked, unlocked, edited projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move "Lock Project" to a separate action.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 27 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.