Page MenuHomePhabricator

Move "Lock Project" to a separate action
ClosedPublic

Authored by epriestley on Dec 27 2015, 3:13 PM.
Tags
None
Referenced Files
F15463223: D14895.id36003.diff
Tue, Apr 1, 9:31 PM
F15460096: D14895.id35992.diff
Mon, Mar 31, 8:05 PM
F15432901: D14895.id.diff
Mon, Mar 24, 8:10 PM
F15428360: D14895.diff
Sun, Mar 23, 7:51 PM
F15403475: D14895.diff
Tue, Mar 18, 3:32 AM
F15403269: D14895.id36003.diff
Tue, Mar 18, 2:32 AM
F15392885: D14895.id.diff
Sat, Mar 15, 6:12 PM
F15389851: D14895.id35992.diff
Sat, Mar 15, 5:42 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rPe8ddfad6dbd2: Move "Lock Project" to a separate action
Summary

Ref T10010. Three motivations:

  • Primarily: this makes conversion to EditEngine easier since I don't have to convert this weird control.
  • This probably needs to have "Lock", "Unlock" and "Use Parent Project Setting" values after subprojects? But maybe just locking any parent locks all the children? Anyway, doesn't make sense to put it on the main edit form if it's weird like this, I think, since we'll want some kind of explanatory text.
  • I probably want to move this to the "Members" tab anyway, and this won't be available on milestone projects at all.
Test Plan

Locked, unlocked, edited projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move "Lock Project" to a separate action.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 27 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.