Differential D14871

Fix project hashtag bugs: allow simultaneously changing name and adding same name as a tag
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 12:35 PM.

Tags

None

Referenced Files

	F13279330: D14871.diff
	Sat, Jun 1, 2:08 PM

	F13266223: D14871.diff
	Tue, May 28, 10:52 AM

	F13250353: D14871.diff
	Fri, May 24, 2:22 PM

	F13229778: D14871.diff
	Mon, May 20, 7:05 PM

	F13226215: D14871.id.diff
	Sun, May 19, 7:42 PM

	F13216307: D14871.id35954.diff
	Fri, May 17, 11:56 PM

	F13210001: D14871.id35947.diff
	Fri, May 17, 3:17 AM

	F13208398: D14871.diff
	Thu, May 16, 2:48 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T8509: Exception when creating project with same tag as primary slug.

Commits

Restricted Diffusion Commit
rP33f55a85b09f: Fix project hashtag bugs: allow simultaneously changing name and adding same…

Summary

Fixes T8509. Changes these behaviors:

If you create a project named "QQQ" and add "qqq" as a hashtag at the same time, it fails in an unhelpful way. (Now: succeeds.)
If you add "qqq" as a hashtag to a project with primary hashtag "qqq", it fails in a correct but probably unnecessary way (Now: just works).

We could make one or both of these behaviors show the user an error instead, but I think it's likely that this behavior is just what they always want.

Test Plan

Added failing tests and made them pass.
Executed both scenarios described above from the web UI.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35947.Dec 24 2015, 12:35 PM

epriestley retitled this revision from to Fix project hashtag bugs: allow simultaneously changing name and adding same name as a tag.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8509: Exception when creating project with same tag as primary slug..

chad accepted this revision.Dec 24 2015, 3:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 24 2015, 3:50 PM

Closed by commit rP33f55a85b09f: Fix project hashtag bugs: allow simultaneously changing name and adding same… (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

__tests__/

PhabricatorProjectCoreTestCase.php

64 lines

editor/

PhabricatorProjectTransactionEditor.php

104 lines

Diff 35954

src/applications/project/tests/PhabricatorProjectCoreTestCase.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...