Page MenuHomePhabricator

Fix project hashtag bugs: duplicate tags, uppercase tags
ClosedPublic

Authored by epriestley on Dec 24 2015, 12:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 6:16 PM
Unknown Object (File)
Fri, Dec 20, 5:59 PM
Unknown Object (File)
Thu, Dec 5, 5:21 PM
Unknown Object (File)
Sun, Dec 1, 6:03 AM
Unknown Object (File)
Fri, Nov 29, 10:48 AM
Unknown Object (File)
Wed, Nov 27, 3:54 AM
Unknown Object (File)
Sat, Nov 23, 11:42 AM
Unknown Object (File)
Nov 19 2024, 11:49 AM
Subscribers
None

Details

Summary

Ref T8509. This fixes three issues:

  • Adding a slug like UPPERCASE would not give you a normalized slug. (Now: normalizes as uppercase.)
  • Adding a slug like UPPERCASE would allow you to give two different projects the different tags UPPERCASE and uppercase (and UpPeRcAsE, etc). (Now: second tag is rejected as a duplicate.)
  • Adding multiple identical or similar slugs would produce a duplicate key exception. (Now: ignores the duplicates.)
Test Plan
  • Added test coverage.
  • Made tests pass.
  • Hit these cases in the UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix project hashtag bugs: duplicate tags, uppercase tags.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:30 PM
This revision was automatically updated to reflect the committed changes.