[ROUGH!] Fix some drag-and-drop issues with Workboards
AbandonedPublic
Actions

Authored by epriestley on Dec 23 2015, 9:32 PM.

Details

Reviewers

chad

Maniphest Tasks

T5240: Dragging items (cards, panels) could be better in Workboards

Summary

Ref T5240. This needs some more work but maybe kick the tires on it and see how it feels?

Basically just JS atrocities:

Move the header nodes around in desktop vs mobile to give us fixed headers.
Resize stuff all the time in JS.

Things that are kind of bad:

Vertical scrollbar is odd and not easily fixable. Maybe just, uh, hide it completely?
I ungood'ed some of the design.
You can't drag cards out of the board area. This doesn't work at HEAD either but needs to work before we can do the drag-to-a-tab UI from M1450.
Icon nav is bleeding into the board now because of reasons.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

proj6

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/projects/behavior-phantom-headers.js:1	JAVELIN5	`javelinsymbols` Not In Path

Unit

Tests Passed

Build Status

Buildable 9755
Build 11719: Run Core Tests
Build 11718: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35933.Dec 23 2015, 9:32 PM

epriestley retitled this revision from to [ROUGH!] Fix some drag-and-drop issues with Workboards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5240: Dragging items (cards, panels) could be better in Workboards.

Herald edited edge metadata. · View Herald TranscriptDec 23 2015, 9:32 PM

rebase?

This one should apply to master now, I think.

Yeah, this is rough. What feedback are you looking for?

Mostly like "does this seem 100% terrible", I guess?

It feels not great, but mostly just CSS stuff that needs cleaned and polished. I also think maybe we can remove the icon nav and use a menu icon like in PHUIDocumentPro.

epriestley mentioned this in T10054: Define product direction for Project/Profile UIs.Dec 24 2015, 4:05 PM

epriestley abandoned this revision.Jan 18 2016, 3:09 PM

epriestley mentioned this in T5240: Dragging items (cards, panels) could be better in Workboards.Feb 8 2016, 7:38 PM