Page MenuHomePhabricator

Implement child/descendant query rules in Projects
ClosedPublic

Authored by epriestley on Dec 23 2015, 3:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 29, 8:12 PM
Unknown Object (File)
Tue, Nov 29, 8:12 PM
Unknown Object (File)
Tue, Nov 29, 8:12 PM
Unknown Object (File)
Tue, Nov 22, 3:03 AM
Unknown Object (File)
Mon, Nov 21, 10:24 PM
Unknown Object (File)
Wed, Nov 16, 6:56 AM
Unknown Object (File)
Fri, Nov 11, 10:08 AM
Unknown Object (File)
Thu, Nov 10, 2:51 AM
Subscribers
None

Details

Summary

Ref T10010. This adds infrastructure for querying projects by type, depth, parent and ancestor.

I needed to revise the "extended policy check" cycle detection rules. When, e.g., querying a grandchild, they incorrectly detected a cycle because both the child and grandchild needed to check the policy of the grandparent.

Instead, simplify it to just do a basic runaway calldepth check. There are many other safety mechanisms to make it so this can't ever occur.

(Cycle detection does have existing test coverage, and those tests still pass, it just takes a little longer to detect the cycle internally.)

There is still no way to create subprojects in the UI.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement child/descendant query rules in Projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 4:47 PM
This revision was automatically updated to reflect the committed changes.