Page MenuHomePhabricator

Implement query and policy rules for subprojects
ClosedPublic

Authored by epriestley on Dec 23 2015, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 9:26 PM
Unknown Object (File)
Sat, Mar 16, 4:44 PM
Unknown Object (File)
Tue, Mar 12, 4:11 PM
Unknown Object (File)
Wed, Mar 6, 4:04 AM
Unknown Object (File)
Tue, Mar 5, 3:44 PM
Unknown Object (File)
Tue, Mar 5, 3:44 PM
Unknown Object (File)
Fri, Mar 1, 4:34 PM
Unknown Object (File)
Feb 18 2024, 4:15 AM
Subscribers
None
Tokens
"Yellow Medal" token, awarded by Luke081515.2.

Details

Summary

Ref T10010. This implements technical groundwork for subprojects. Specifically, it implements policy rules like Phriction:

  • to see a project, you must be able to see all of its parents (and the project itself).
  • you can edit a project if you can edit any of its parents (or the project itself).

To facilitiate this, we load all project ancestors when querying projects so we can do the view/edit checks.

This does NOT yet implement:

  • proper membership rules for these projects (up next);
  • any kind of UI to let users create subprojects.
Test Plan
  • Added unit tests.
  • Executed unit tests.
  • Browsed Projects (no change in behavior is expected).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement query and policy rules for subprojects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 4:41 PM
This revision was automatically updated to reflect the committed changes.