Page MenuHomePhabricator
Differential D14856

Disable live previews on mobile
ClosedPublic
Actions

Authored by epriestley on Dec 22 2015, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 11, 2:47 PM
Unknown Object (File)
Sun, Feb 9, 2:37 PM
Unknown Object (File)
Sun, Feb 9, 2:37 PM
Unknown Object (File)
Sun, Feb 9, 12:14 AM
Unknown Object (File)
Sun, Feb 9, 12:14 AM
Unknown Object (File)
Sun, Feb 9, 12:14 AM
Unknown Object (File)
Mon, Feb 3, 9:13 PM
Unknown Object (File)
Wed, Jan 29, 2:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T1895: Disable live previews
Commits
Restricted Diffusion Commit
rP8752bd4966f1: Disable live previews on mobile
Summary

Fixes T1895. Now that we have on-demand prviews, we can use them on mobile. On mobile:

  • don't show live previews;
  • only save drafts every 10 seconds.

Also, show fewer remarkup buttons on mobile to try to make sure the more important ones (preview, e.g.) fit.

Test Plan
  • Made window narrower and wider to trigger preview/no-preview behavior.
  • Used DarkConsole to verify request rate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35913.Dec 22 2015, 8:40 PM
epriestley retitled this revision from to Disable live previews on mobile.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T1895: Disable live previews .
Herald edited edge metadata. · View Herald TranscriptDec 22 2015, 8:40 PM
chad accepted this revision.Dec 22 2015, 8:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 8:49 PM
Closed by commit rP8752bd4966f1: Disable live previews on mobile (authored by epriestley, committed by epriestley). · Explain WhyDec 22 2015, 8:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
src/
view/
form/
control/
14 lines
webroot/
rsrc/
css/
core/
4 lines
js/
application/
transactions/
22 lines

Diff 35914

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...
Phabricator · Built by Phacility