Page MenuHomePhabricator
Differential D14842

Convert all "DocumentIndexers" into "FulltextEngines"
ClosedPublic
Actions

Authored by epriestley on Dec 21 2015, 6:18 PM.
Tags
None
Referenced Files
F18506920: D14842.id.diff
Fri, Sep 5, 1:52 AM
F18499661: D14842.diff
Thu, Sep 4, 7:58 PM
F18318695: D14842.id.diff
Sun, Aug 24, 12:01 PM
F18180715: D14842.id35877.diff
Sat, Aug 16, 6:39 AM
F17949039: D14842.id.diff
Jul 31 2025, 10:42 PM
F17924393: D14842.diff
Jul 30 2025, 9:57 AM
F17708024: D14842.id35894.diff
Jul 16 2025, 4:04 PM
F17703991: D14842.diff
Jul 16 2025, 2:55 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles)
Commits
Restricted Diffusion Commit
rP99c9df96b4ff: Convert all "DocumentIndexers" into "FulltextEngines"
Summary

Ref T9979. This simplifies/standardizes the code a bit, but mostly gives us more consistent class names and structure.

Test Plan
  • Used bin/search index --type ... to index documents of every indexable type.
  • Searched for documents by unique text, found them.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35875.Dec 21 2015, 6:18 PM
epriestley retitled this revision from to Convert all "DocumentIndexers" into "FulltextEngines".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).
epriestley updated this revision to Diff 35877.Dec 21 2015, 6:45 PM
  • Undo debugging comment.
chad accepted this revision.Dec 21 2015, 8:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 8:22 PM
Closed by commit rP99c9df96b4ff: Convert all "DocumentIndexers" into "FulltextEngines" (authored by epriestley, committed by epriestley). · Explain WhyDec 22 2015, 1:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
74 lines
applications/
calendar/
search/
39 lines
storage/
12 lines
differential/
search/
64 lines
storage/
12 lines
diviner/
search/
26 lines
DivinerLiveSymbolFulltextEngine.php
DivinerAtomSearchIndexer.php
28 lines
storage/
11 lines
15 lines
fund/
search/
34 lines
storage/
11 lines
maniphest/
search/
ManiphestTaskFulltextEngine.php
ManiphestSearchIndexer.php
33 lines
storage/
11 lines
passphrase/
search/
27 lines
storage/
12 lines
people/
search/
22 lines
storage/
11 lines
pholio/
search/
25 lines
storage/
11 lines
phriction/
search/
44 lines
storage/
11 lines
ponder/
search/
24 lines
storage/
11 lines
project/
search/
24 lines
storage/
12 lines
repository/
search/
49 lines
storage/
10 lines
search/
engineextension/
30 lines
34 lines
index/
54 lines
15 lines
interface/
7 lines
management/
55 lines
query/
18 lines
worker/
2 lines

Diff 35894

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/search/PhabricatorCalendarEventFulltextEngine.php

Loading...
View Options

src/applications/calendar/search/PhabricatorCalendarEventSearchIndexer.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/differential/search/DifferentialRevisionFulltextEngine.php

Loading...
View Options

src/applications/differential/search/DifferentialSearchIndexer.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/diviner/search/DivinerAtomSearchIndexer.php

Loading...
View Options

src/applications/diviner/search/DivinerBookSearchIndexer.php

Loading...
View Options

src/applications/diviner/search/DivinerLiveBookFulltextEngine.php

Loading...
View Options

src/applications/diviner/search/DivinerLiveSymbolFulltextEngine.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveBook.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

Loading...
View Options

src/applications/fund/search/FundInitiativeFulltextEngine.php

Loading...
View Options

src/applications/fund/search/FundInitiativeIndexer.php

Loading...
View Options

src/applications/fund/storage/FundInitiative.php

Loading...
View Options

src/applications/maniphest/search/ManiphestSearchIndexer.php

Loading...
View Options

src/applications/maniphest/search/ManiphestTaskFulltextEngine.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/passphrase/search/PassphraseCredentialFulltextEngine.php

Loading...
View Options

src/applications/passphrase/search/PassphraseSearchIndexer.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/people/search/PhabricatorUserFulltextEngine.php

Loading...
View Options

src/applications/people/search/PhabricatorUserSearchIndexer.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/pholio/search/PholioMockFulltextEngine.php

Loading...
View Options

src/applications/pholio/search/PholioSearchIndexer.php

Loading...
View Options

src/applications/pholio/storage/PholioMock.php

Loading...
View Options

src/applications/phriction/search/PhrictionDocumentFulltextEngine.php

Loading...
View Options

src/applications/phriction/search/PhrictionSearchIndexer.php

Loading...
View Options

src/applications/phriction/storage/PhrictionDocument.php

Loading...
View Options

src/applications/ponder/search/PonderQuestionFulltextEngine.php

Loading...
View Options

src/applications/ponder/search/PonderSearchIndexer.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestion.php

Loading...
View Options

src/applications/project/search/PhabricatorProjectFulltextEngine.php

Loading...
View Options

src/applications/project/search/PhabricatorProjectSearchIndexer.php

Loading...
View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
View Options

src/applications/repository/search/DiffusionCommitFulltextEngine.php

Loading...
View Options

src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorFulltextIndexEngineExtension.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorLiskFulltextEngineExtension.php

Loading...
View Options

src/applications/search/index/PhabricatorFulltextEngine.php

Loading...
View Options

src/applications/search/index/PhabricatorIndexEngine.php

Loading...
View Options

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...
View Options

src/applications/search/interface/PhabricatorFulltextInterface.php

Loading...
View Options

src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/search/worker/PhabricatorSearchWorker.php

Loading...
Phabricator · Built by Phacility