Don't show "master (branched from master)" in UI
ClosedPublic
Actions

Authored by epriestley on Dec 19 2015, 8:56 PM.

Details

Reviewers

chad

Maniphest Tasks

T3462: In Differential, expose "featurename (branched from master)" via Conduit

Commits

Restricted Diffusion Commit
rP8a81d208c487: Don't show "master (branched from master)" in UI

Summary

Ref T3462. If someone works directly on master, we currently show "Branch: master (branched from master)" in the UI.

Although this is sort of technically accurate, it is confusing.

Instead, just show "Branch: master" in this situation.

Test Plan

Saw "master" instead of "master (branched from master)".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35854.Dec 19 2015, 8:56 PM

epriestley retitled this revision from to Don't show "master (branched from master)" in UI.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T3462: In Differential, expose "featurename (branched from master)" via Conduit.

chad accepted this revision.Dec 19 2015, 8:57 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 19 2015, 8:57 PM

Closed by commit rP8a81d208c487: Don't show "master (branched from master)" in UI (authored by epriestley, committed by epriestley). · Explain WhyDec 19 2015, 8:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialBranchField.php

2 lines

Diff 35856

View Options

src/applications/differential/customfield/DifferentialBranchField.php

Don't show "master (branched from master)" in UIClosedPublicActions