This is just putting a hook in that pretty much works. Behavior:
- If you visit /maniphest/?nux=true, it always shows NUX for testing.
- Otherwise, it shows NUX if there are no objects in the application yet.
Details
Details
- Reviewers
chad - Commits
- Restricted Diffusion Commit
rPdbb84f1ddc12: Add basic NUX support to SearchEngines
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/maniphest/query/ManiphestTaskSearchEngine.php | ||
|---|---|---|
| 388–394 ↗ | (On Diff #35851) | I'll delete these before landing if the rest of this seems reasonable. |
| src/applications/search/controller/PhabricatorApplicationSearchController.php | ||
|---|---|---|
| 232 | erm, where do I drop this new function? I tried SearchEngine but it complains about being final. | |
Comment Actions
Yeah, the naming is really confusing right now (I'm going to fix that as part of T9979.
SearchEngine is about fulltext search and search indexing. I'm going to rename that to IndexEngine.
ApplicationSearchEngine is what you want.
To get a basic version working:
- Implement getNewUserHeader() getNewUserBody() in an ApplicationSearchEngine subclass like ManiphestTaskSearchEngine.
- Visit /maniphest/?nux=true.
- To get fancier, mess around with PhabricatorApplicationSearchEngine-> renderNewUserView() (see inline).
- This will be less confusing soon.
| src/applications/search/engine/PhabricatorApplicationSearchEngine.php | ||
|---|---|---|
| 1357–1371 | Mess with this to get a fancier UI. | |