Page MenuHomePhabricator
Differential D14827

Add a Read More link to PHUIDocumentSummaryView
ClosedPublic
Actions

Authored by chad on Dec 19 2015, 8:02 PM.
Tags
None
Referenced Files
F15508895: D14827.id.diff
Wed, Apr 16, 7:03 AM
F15508337: D14827.id35850.diff
Wed, Apr 16, 4:54 AM
F15505840: D14827.diff
Tue, Apr 15, 6:19 AM
F15505642: D14827.diff
Tue, Apr 15, 4:38 AM
F15482248: D14827.id35852.diff
Wed, Apr 9, 3:50 AM
F15481780: D14827.id35848.diff
Tue, Apr 8, 10:50 PM
F15481579: D14827.id35850.diff
Tue, Apr 8, 9:57 PM
F15475481: D14827.diff
Sun, Apr 6, 7:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP9d1ba9c03808: Add a Read More link to PHUIDocumentSummaryView
Summary

Currently it's difficult to notice posts may be much longer than the summary (in most cases, actually), Adds a consistent "Read More" link to the full post. Also made sure "violet" was more consistantly used.

Test Plan

Review summaries in Phame

pasted_file (855×861 px, 175 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35848.Dec 19 2015, 8:02 PM
chad retitled this revision from to Add a Read More link to PHUIDocumentSummaryView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 19 2015, 8:02 PM
chad edited the test plan for this revision. (Show Details)Dec 19 2015, 8:05 PM
chad updated this revision to Diff 35850.Dec 19 2015, 8:29 PM
  • Clean up bottom spacing
epriestley accepted this revision.Dec 19 2015, 8:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2015, 8:45 PM
Closed by commit rP9d1ba9c03808: Add a Read More link to PHUIDocumentSummaryView (authored by chad, committed by chad). · Explain WhyDec 19 2015, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
view/
phui/
10 lines
webroot/
rsrc/
css/
application/
phame/
6 lines
phui/
19 lines

Diff 35852

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIDocumentSummaryView.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document-summary.css

Loading...
Phabricator · Built by Phacility