Page MenuHomePhabricator

Allow custom fields to be ordered ascending or descending
ClosedPublic

Authored by epriestley on Dec 16 2015, 8:20 PM.
Tags
None
Referenced Files
F14054341: D14800.diff
Sat, Nov 16, 12:42 AM
F14043015: D14800.diff
Tue, Nov 12, 7:19 AM
F14027924: D14800.diff
Fri, Nov 8, 10:51 AM
F14008748: D14800.diff
Wed, Oct 30, 6:12 AM
Unknown Object (File)
Oct 9 2024, 1:15 AM
Unknown Object (File)
Sep 9 2024, 2:00 PM
Unknown Object (File)
Sep 2 2024, 2:19 AM
Unknown Object (File)
Aug 29 2024, 1:33 PM
Subscribers
None

Details

Summary

Fixes T6864. This creates a sort of busy menu but I think that's proably fine -- users are opting into activating these fields for search anyway.

In the future, we could refine this as, e.g.:

  • don't show these options in the dropdown;
  • do show them on some new "http prefilling" sort of page;
  • then you access them as an advanced user with ?order=secret-magic.

But I'm not going to bother for now.

Test Plan

Ordered by an int field, then reversed the order.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow custom fields to be ordered ascending or descending.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.