Page MenuHomePhabricator

Allow login to be disabled for authentication providers
ClosedPublic

Authored by epriestley on Dec 15 2015, 10:52 PM.
Tags
None
Referenced Files
F15444613: D14794.id35771.diff
Thu, Mar 27, 10:22 AM
F15443853: D14794.id35769.diff
Thu, Mar 27, 6:31 AM
F15443471: D14794.id.diff
Thu, Mar 27, 4:36 AM
F15440453: D14794.diff
Wed, Mar 26, 12:54 PM
F15422547: D14794.id35769.diff
Sat, Mar 22, 9:17 AM
F15401657: D14794.id.diff
Mon, Mar 17, 6:42 PM
F15396274: D14794.id35771.diff
Sun, Mar 16, 1:07 PM
F15380184: D14794.diff
Fri, Mar 14, 1:52 AM
Subscribers
None

Details

Summary

Fixes T9997. This was in the database since v0, I just never hooked up the UI since it wasn't previously meaningful.

However, it now makes sense to have a provider like Asana with login disabled and use it only for integrations.

Test Plan

Disabled login on a provider, verified it was no longer available for login/registration but still linkable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow login to be disabled for authentication providers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Specifically, per T9997, a use case for this is:

  • You want to require login through Google, or some other provider with strong identity guarantees (e.g., mandatory MFA).
  • You also want integrations with an external OAuth system like Asana or JIRA, or other systems in the future.

This is incidentally convenient for us as Phacility since we want instance users to login through central auth, but the primary use case is a reasonable one in geneal.

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2015, 10:58 PM
This revision was automatically updated to reflect the committed changes.