Page MenuHomePhabricator

Clean up "ids" and "phids" handling in SearchEngines
ClosedPublic

Authored by epriestley on Dec 13 2015, 6:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 3:57 AM
Unknown Object (File)
Mon, Apr 29, 4:07 PM
Unknown Object (File)
Wed, Apr 24, 11:54 PM
Unknown Object (File)
Fri, Apr 12, 10:45 AM
Unknown Object (File)
Fri, Apr 12, 4:50 AM
Unknown Object (File)
Thu, Apr 11, 8:11 AM
Unknown Object (File)
Wed, Apr 10, 7:45 AM
Unknown Object (File)
Wed, Apr 10, 7:45 AM
Subscribers
None

Details

Summary

Ref T9964. I added several hacks to get these working. Clean them up and pull this into a proper extension.

The behavior in the web UI is:

  • they work in all applications; but
  • they only show up in the UI if a value is specified.

So if you visit /view/?ids=1,2 you get the field, but normally it's not present. We could refine this later. I'm going to add documentation about how to prefill these forms regardless, which should make this discoverable by reading the documentation.

There's one teensey weensey hack: in the API, I push these fields to the top of the table. That one feels OK, since it's purely a convenience/display adjustment.

Test Plan

Queried by IDs, reviewed docs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35708.
epriestley retitled this revision from to Clean up "ids" and "phids" handling in SearchEngines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Clean build?
  • Fix other actual functional problems.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 7:59 PM
This revision was automatically updated to reflect the committed changes.