Page MenuHomePhabricator

Give ConduitAPIMethod->getMethodDescription() access to a real Viewer
ClosedPublic

Authored by epriestley on Dec 13 2015, 10:47 AM.
Tags
None
Referenced Files
F14057947: D14761.diff
Sun, Nov 17, 8:14 AM
F14039928: D14761.diff
Mon, Nov 11, 6:46 AM
F14019430: D14761.diff
Tue, Nov 5, 10:06 PM
F14012026: D14761.diff
Fri, Nov 1, 6:58 AM
F14000838: D14761.diff
Fri, Oct 25, 1:38 AM
F13994538: D14761.id.diff
Wed, Oct 23, 6:50 AM
F13986474: D14761.diff
Mon, Oct 21, 3:14 AM
F13961067: D14761.id35714.diff
Oct 15 2024, 2:57 AM
Subscribers
None

Details

Summary

Ref T9964. The new *.search and *.edit methods generate documentation which depends on the viewer.

For example, the *.search methods show a reference table of the keys for all your saved queries.

Give them a real viewer to work with.

During normal execution, just populate this viewer with the request's viewer, so $request->getViewer() and $this->getViewer() both work and mean the same thing.

Test Plan

Screen Shot 2015-12-13 at 2.44.37 AM.png (229×539 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give ConduitAPIMethod->getMethodDescription() access to a real Viewer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 3:23 PM
epriestley edited edge metadata.
  • Clean tests.
This revision was automatically updated to reflect the committed changes.