Page MenuHomePhabricator

Give ConduitAPIMethod->getMethodDescription() access to a real Viewer
ClosedPublic

Authored by epriestley on Dec 13 2015, 10:47 AM.
Tags
None
Referenced Files
F18726618: D14761.id.diff
Tue, Sep 30, 6:46 AM
F18717956: D14761.diff
Mon, Sep 29, 3:02 PM
F18704154: D14761.id35714.diff
Sun, Sep 28, 6:25 AM
F18672641: D14761.diff
Thu, Sep 25, 7:59 AM
F18621895: D14761.id35694.diff
Mon, Sep 15, 9:51 AM
F18506833: D14761.id.diff
Fri, Sep 5, 1:49 AM
F18499560: D14761.diff
Sep 4 2025, 7:52 PM
F17781300: D14761.diff
Jul 24 2025, 6:15 AM
Subscribers
None

Details

Summary

Ref T9964. The new *.search and *.edit methods generate documentation which depends on the viewer.

For example, the *.search methods show a reference table of the keys for all your saved queries.

Give them a real viewer to work with.

During normal execution, just populate this viewer with the request's viewer, so $request->getViewer() and $this->getViewer() both work and mean the same thing.

Test Plan

Screen Shot 2015-12-13 at 2.44.37 AM.png (229×539 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give ConduitAPIMethod->getMethodDescription() access to a real Viewer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 3:23 PM
epriestley edited edge metadata.
  • Clean tests.
This revision was automatically updated to reflect the committed changes.