Paths

Table of Contentst

Differential D14745

Throw CommandException instead of Exception after `git fetch` failure in repository updates
ClosedPublic
Actions

Authored by epriestley on Dec 12 2015, 12:52 AM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T9966: Diffusion credentials may be leaked under some circumstances

Commits

Restricted Diffusion Commit
rP7b997359466f: Throw CommandException instead of Exception after `git fetch` failure in…

Summary

Fixes T9966. In this unusual, difficult-to-reach case, we throw Exception (which has no censoring) instead of CommandException (which has censoring). Throw CommandException instead.

Test Plan

Hacked up a bunch of stuff in order to hit this: disabled origin validation, origin correction, and pointed repository at a bad domain.
Verified message is now censored correctly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35660.Dec 12 2015, 12:52 AM

epriestley retitled this revision from to Throw CommandException instead of Exception after `git fetch` failure in repository updates.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9966: Diffusion credentials may be leaked under some circumstances.

chad accepted this revision.Dec 12 2015, 12:52 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 12 2015, 12:52 AM

Closed by commit rP7b997359466f: Throw CommandException instead of Exception after `git fetch` failure in… (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2015, 12:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

12 lines

Diff 35661

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...