Page MenuHomePhabricator

Mark external -> external redirects in Phame to canonicalize URIs as "external"
ClosedPublic

Authored by epriestley on Dec 11 2015, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 5:36 PM
Unknown Object (File)
Mon, Mar 11, 1:17 AM
Unknown Object (File)
Thu, Mar 7, 5:00 PM
Unknown Object (File)
Thu, Mar 7, 5:00 PM
Unknown Object (File)
Tue, Mar 5, 6:56 AM
Unknown Object (File)
Tue, Mar 5, 1:42 AM
Unknown Object (File)
Feb 19 2024, 1:18 AM
Unknown Object (File)
Feb 16 2024, 5:34 AM
Subscribers
None

Details

Summary

Ref T9897. If you visit /post/123/spoderman/ it will try to redirect you to /post/123/spiderman/, but currently only internal views work because these redirects aren't marked as safe/external.

Test Plan

Visited a misspelled/out-of-date URI on an external blog view, got a good redirect.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Mark external -> external redirects in Phame to canonicalize URIs as "external".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2015, 4:34 PM
This revision was automatically updated to reflect the committed changes.