Page MenuHomePhabricator

Mark external -> external redirects in Phame to canonicalize URIs as "external"
ClosedPublic

Authored by epriestley on Dec 11 2015, 4:30 PM.
Tags
None
Referenced Files
F18092015: D14741.diff
Thu, Aug 7, 4:06 AM
F18085458: D14741.diff
Tue, Aug 5, 7:14 PM
Unknown Object (File)
Jun 16 2025, 12:51 PM
Unknown Object (File)
May 10 2025, 3:01 AM
Unknown Object (File)
May 10 2025, 3:01 AM
Unknown Object (File)
May 9 2025, 4:05 PM
Unknown Object (File)
Apr 30 2025, 2:30 PM
Unknown Object (File)
Apr 30 2025, 7:17 AM
Subscribers
None

Details

Summary

Ref T9897. If you visit /post/123/spoderman/ it will try to redirect you to /post/123/spiderman/, but currently only internal views work because these redirects aren't marked as safe/external.

Test Plan

Visited a misspelled/out-of-date URI on an external blog view, got a good redirect.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Mark external -> external redirects in Phame to canonicalize URIs as "external".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2015, 4:34 PM
This revision was automatically updated to reflect the committed changes.