Page MenuHomePhabricator

Default "Land Revision" dialog to land into the default branch for the repository
ClosedPublic

Authored by epriestley on Dec 10 2015, 10:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 6:50 AM
Unknown Object (File)
Tue, Dec 10, 8:49 AM
Unknown Object (File)
Sat, Dec 7, 9:58 AM
Unknown Object (File)
Fri, Dec 6, 7:01 AM
Unknown Object (File)
Tue, Dec 3, 6:58 AM
Unknown Object (File)
Sun, Dec 1, 10:18 AM
Unknown Object (File)
Sun, Dec 1, 10:18 AM
Unknown Object (File)
Sun, Dec 1, 10:17 AM
Subscribers
None

Details

Summary

Ref T9952. Default the branch target in the dialog to be whatever branch is the default branch for the repository.

This will be correct for repositories like ours (which land everything into master) and correct most of the time for repositories which have some other "primary" branch (maybe development).

It won't be great if there are multiple open lines of development in a repository (for example, some changes go to newdesignpro and some changes go to legacy-1.2). I'll do work in T3462 next to improve those cases so we can pick a better default.

Test Plan
  • Saw dialog default to "master".
  • Changed repo default branch, saw it default to "notmaster" instead.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Default "Land Revision" dialog to land into the default branch for the repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 10:11 PM
This revision was automatically updated to reflect the committed changes.