Paths

Table of Contentst

Differential D14733

Add an "Onto Branch" selector control to "Land Revision" dialog
ClosedPublic
Actions

Authored by epriestley on Dec 10 2015, 9:50 PM.

Details

Reviewers

chad

Maniphest Tasks

T9952: Let "Land Revision" target branches other than master

Commits

Restricted Diffusion Commit
rP856bdaf77e8f: Add an "Onto Branch" selector control to "Land Revision" dialog

Summary

Ref T9952. This adds a typeahead so you can pick a branch to target.

It does not choose a default branch, the user must pick a branch explicitly.

Test Plan

Landed rGITTESTd587fada48fc to master (by typing "master").
Landed rGITTEST86c339b2ef01 to notmaster (by typing "notmaster").

Screen Shot 2015-12-10 at 1.35.20 PM.png (379×648 px, 37 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35626.Dec 10 2015, 9:50 PM

epriestley retitled this revision from to Add an "Onto Branch" selector control to "Land Revision" dialog.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9952: Let "Land Revision" target branches other than master.

chad accepted this revision.Dec 10 2015, 10:02 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 10 2015, 10:02 PM

Closed by commit rP856bdaf77e8f: Add an "Onto Branch" selector control to "Land Revision" dialog (authored by epriestley, committed by epriestley). · Explain WhyDec 10 2015, 10:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionOperationController.php

97 lines

repository/

phid/

PhabricatorRepositoryRefCursorPHIDType.php

4 lines

Diff 35633

View Options

src/applications/differential/controller/DifferentialRevisionOperationController.php