Page MenuHomePhabricator
Differential D14732

Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and refs
ClosedPublic
Actions

Authored by epriestley on Dec 10 2015, 9:18 PM.
Tags
None
Referenced Files
F13283702: D14732.diff
Sun, Jun 2, 4:10 PM
F13278670: D14732.diff
Sat, Jun 1, 2:03 AM
F13269427: D14732.diff
Wed, May 29, 6:19 AM
F13254316: D14732.id35632.diff
Sat, May 25, 3:19 AM
F13252648: D14732.diff
Sat, May 25, 1:55 AM
F13248308: D14732.id35632.diff
Fri, May 24, 2:30 AM
F13248307: D14732.id35625.diff
Fri, May 24, 2:30 AM
F13248306: D14732.id.diff
Fri, May 24, 2:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9952: Let "Land Revision" target branches other than master
Commits
Restricted Diffusion Commit
rP8dcdc7534d9c: Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and…
Summary

Ref T9952. This will let me put a "Branch: [____]" control on the "Land Revision" dialog so users can choose a branch to target.

Test Plan

Used /typeahead/class/ to vet basic behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35625.Dec 10 2015, 9:18 PM
epriestley retitled this revision from to Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and refs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9952: Let "Land Revision" target branches other than master.
chad accepted this revision.Dec 10 2015, 9:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 9:23 PM
Closed by commit rP8dcdc7534d9c: Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and… (authored by epriestley, committed by epriestley). · Explain WhyDec 10 2015, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
typeahead/
50 lines
repository/
query/
13 lines

Diff 35632

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionRefDatasource.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

Loading...
Phabricator · Built by Phacility