Page MenuHomePhabricator

Implement DestructibleInterface for Owners Packages
ClosedPublic

Authored by epriestley on Dec 10 2015, 1:18 PM.
Tags
None
Referenced Files
F13121320: D14729.diff
Mon, Apr 29, 4:48 PM
Unknown Object (File)
Thu, Apr 25, 12:24 AM
Unknown Object (File)
Thu, Apr 11, 8:59 AM
Unknown Object (File)
Mon, Apr 8, 5:46 PM
Unknown Object (File)
Sat, Apr 6, 11:38 PM
Unknown Object (File)
Sat, Apr 6, 3:29 PM
Unknown Object (File)
Mar 11 2024, 7:10 PM
Unknown Object (File)
Mar 11 2024, 6:51 PM
Subscribers
None

Details

Summary

Fixes T9945. This is straightforward.

The two sub-object types are very lightweight so I just deleted them directly instead of loading + delete()'ing (or implementing DestructibleInterface on them, which would require they have PHIDs).

Also improve a US English localization.

Test Plan
  • Used bin/remove destroy PHID-... --trace to destroy a package.
  • Verified it was gone.
  • Inspected the SQL in the log for general reasonableness.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement DestructibleInterface for Owners Packages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 3:03 PM
This revision was automatically updated to reflect the committed changes.