Clean up some custom field strings in Feed
ClosedPublic
Actions

Authored by epriestley on Dec 9 2015, 5:01 PM.

Details

Reviewers

Maniphest Tasks

T9919: Display change between usernames for custom field of type "user" instead the PHID-USER-* in the Recent Activity feed

Commits

Restricted Diffusion Commit
rPd57cc740ca29: Clean up some custom field strings in Feed

Summary

Fixes T9919. We were missing feed strings and US English localizations for some of this stuff.

Test Plan

Before:

After:

Screen Shot 2015-12-09 at 8.59.01 AM.png (388×492 px, 59 KB)

Screen Shot 2015-12-09 at 8.58.34 AM.png (201×459 px, 30 KB)

Screen Shot 2015-12-09 at 8.58.54 AM.png (164×492 px, 31 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35603.Dec 9 2015, 5:01 PM

epriestley retitled this revision from to Clean up some custom field strings in Feed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9919: Display change between usernames for custom field of type "user" instead the PHID-USER-* in the Recent Activity feed.

chad accepted this revision.Dec 9 2015, 5:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2015, 5:03 PM

Closed by commit rPd57cc740ca29: Clean up some custom field strings in Feed (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2015, 5:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldPHIDs.php

40 lines

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

18 lines

Diff 35604

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php