Page MenuHomePhabricator

Explain why older changes are hidden more clearly
ClosedPublic

Authored by epriestley on Dec 9 2015, 2:45 PM.

Details

Summary

Fixes T9920. When hiding changes, tell users why so they can learn the comment rule (usually, "Changes from before your most recent comment are hidden."; sometimes they're hidden for pagination reasons).

Also use "Show Older Comments" instead of "Show older comments." for the action since I think it's a little more consistent to use title case for links/actions?

Test Plan
  • Viewed a task with a lot of comments, saw a "most recent comment" element.
  • Artificially set page size to 3, saw a "lots of changes" hide.
  • Grepped for removed string.
  • Clicked both "show older stuff" links.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Explain why older changes are hidden more clearly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2015, 2:53 PM
This revision was automatically updated to reflect the committed changes.