Moves New Post and Move Post to be separate Controllers with Dialogs. Ref T9897
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T9897: Unbeta Feedback on Phame
- Commits
- Restricted Diffusion Commit
rPafacdbd814cc: Use AphrontDialog for New/Move Phame Posts
Move a post to a new blog, see message and see post. Click New Post, get dialog, pick blog, edit new post.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/phame/controller/PhameHomeController.php | ||
|---|---|---|
| 87–96 | I think we should drop this "select a blog from a dropdown" workflow entirely, it feels really clunky/unintuitive to me? Do you think it's useful? | |
| src/applications/phame/controller/post/PhamePostMoveController.php | ||
| 12 | It is possible for $id to not be present? I think we'll always have $id? | |
| 18 | For consistency, pass both CAN_VIEW and CAN_EDIT. | |
| src/applications/phame/controller/post/PhamePostNewController.php | ||
| 3 | That is, I'd be completely onboard with just deleting this workflow completely. | |
| src/applications/phame/controller/PhameHomeController.php | ||
|---|---|---|
| 87–96 | This is basically to resolve the "I landed on /phame/ and want to just post something" flow. Or do you think that should be an EditEngine dropdown? Not sure what all magic is possible. | |
Comment Actions
The "Choose a blog from a dropdown" flow just feels bad to me every time I hit it. I'd much rather select a blog from the blog list (with icons, context, etc) than from a dropdown, and this dropdown flow doesn't really reduce the number of steps. Having multiple "New Thing" buttons also feels really weird to me.
We could make the dropdown be "New post on A", "New post on B" for every possible blog, but I think that's even worse.
If you want to give write-workflows a little more support on the home page, maybe we could explore a more dashboard-like view? Like:
- Posts from all blogs
- If you have any drafts, quick links to your ~5 most recent drafts plus a "view all..."
- If you've ever written posts, quick links to the ~5 most recent blogs you've contributed to with "Write another post", plus "View all..."
But I can just make a dashboard for myself with this stuff too if you want to keep the Phame homepage clean.
Comment Actions
Or, more minimally, add these items to the dropdown:
- View Drafts (takes you straight to /phame/post/query/draft/).
- Write Post (takes you straight to a new /phame/blog/query/writable/ which shows writable, active blogs).
Comment Actions
Yeah, I'll add those actions, and probably leave the dialog. Main concern is this spending more time on Phame (in general) probably isn't justifiable. To do it "write" I'd want to list blogs and recent posts on the main page, which would be more custom UI. I'd rather launch and get feedback on it's actual use. Dashboard-ish is certainly worth pursuing v2.