Page MenuHomePhabricator
Differential D14693

Populate the "Quick Create" menu from EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 7 2015, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 8:34 PM
Unknown Object (File)
Fri, Jan 24, 10:19 AM
Unknown Object (File)
Fri, Jan 24, 10:18 AM
Unknown Object (File)
Fri, Jan 24, 10:18 AM
Unknown Object (File)
Thu, Jan 23, 8:03 PM
Unknown Object (File)
Tue, Jan 21, 3:44 PM
Unknown Object (File)
Tue, Jan 21, 11:56 AM
Unknown Object (File)
Fri, Jan 17, 8:16 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter
Commits
Restricted Diffusion Commit
rPe7fc2a387bcb: Populate the "Quick Create" menu from EditEngine
Summary

Ref T9908. When there are custom / renamed / policy considerations for applications, respect them in the quick create menu.

This has some performance implications, in that it makes every page slower by two queries (and potentially more, soon), which is quite bad. I have some ideas to mitigate this, but it's not the end of the world to eat these queries for now.

Test Plan

Screen Shot 2015-12-07 at 10.57.30 AM.png (360×223 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35536.Dec 7 2015, 7:00 PM
epriestley retitled this revision from to Populate the "Quick Create" menu from EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
chad accepted this revision.Dec 7 2015, 7:04 PM
chad edited edge metadata.

v nice.

This revision is now accepted and ready to land.Dec 7 2015, 7:04 PM
Closed by commit rPe7fc2a387bcb: Populate the "Quick Create" menu from EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 7 2015, 7:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
home/
application/
2 lines
maniphest/
application/
12 lines
paste/
application/
12 lines
transactions/
editengine/
70 lines
storage/
4 lines

Diff 35540

View Options

src/applications/home/application/PhabricatorHomeApplication.php

Loading...
View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...
View Options

src/applications/paste/application/PhabricatorPasteApplication.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

Loading...
Phabricator · Built by Phacility