Page MenuHomePhabricator

Unify EditEngine preview behavior; prepare for saving complex drafts
ClosedPublic

Authored by epriestley on Dec 4 2015, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 3:57 AM
Unknown Object (File)
Fri, Dec 13, 2:44 AM
Unknown Object (File)
Sun, Dec 8, 4:27 AM
Unknown Object (File)
Fri, Dec 6, 3:52 AM
Unknown Object (File)
Sun, Dec 1, 7:32 AM
Unknown Object (File)
Sun, Dec 1, 7:32 AM
Unknown Object (File)
Sun, Dec 1, 7:31 AM
Unknown Object (File)
Wed, Nov 27, 5:26 PM
Subscribers
None

Details

Summary

Ref T9132. We currently have an old preview/draft behavior and a new actions behavior.

Let the actions behavior do drafts/previews too, so we can eventually throw away the old thing.

This is pretty much just copying the old behavior into the new one, but with a few tweaks. The major change is that we submit all the stacked actions behavior now, so the preview reflects everything the change will do (and, soon, we can save it in the draft in a consistent way).

Also includes one hack-fix that I'll clean up at some point.

Test Plan

Added a bunch of stacked actions and observed meaningful previews.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Unify EditEngine preview behavior; prepare for saving complex drafts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2015, 10:46 PM
This revision was automatically updated to reflect the committed changes.