Page MenuHomePhabricator

Replace all Maniphest commenting code with EditEngine commenting code
ClosedPublic

Authored by epriestley on Dec 4 2015, 2:43 PM.
Tags
None
Referenced Files
F14055032: D14663.diff
Sat, Nov 16, 7:36 AM
F14043896: D14663.diff
Tue, Nov 12, 1:48 PM
F14025851: D14663.diff
Thu, Nov 7, 8:52 PM
F13974664: D14663.diff
Oct 18 2024, 6:43 AM
F13974009: D14663.id35489.diff
Oct 18 2024, 3:38 AM
F13971348: D14663.id.diff
Oct 17 2024, 12:56 PM
Unknown Object (File)
Sep 17 2024, 3:17 AM
Unknown Object (File)
Sep 15 2024, 7:42 PM
Subscribers
None

Details

Summary

Ref T9132. Like D14659, I'll hold this until after the cut.

This swaps commenting in Maniphest over to EditEngine / stackable actions. New code doesn't have parity yet, although none of the things we're missing should technically be strictly mandatory. There's a list inline. I'll restore these in the next diffs.

Briefly -- comments, subscribers and projects work. Status, owners and priority do not yet.

Test Plan
  • Made comments and added subscribers and projects.
  • Read through the old code to look for missing features and tried to document them all.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Replace all Maniphest commenting code with EditEngine commenting code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2015, 5:39 PM
This revision was automatically updated to reflect the committed changes.