Page MenuHomePhabricator
Differential D14660

Spiffy up PhamePostView
ClosedPublic
Actions

Authored by chad on Dec 3 2015, 11:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 7:14 PM
Unknown Object (File)
Fri, Dec 6, 4:41 PM
Unknown Object (File)
Mon, Dec 2, 9:10 AM
Unknown Object (File)
Sun, Dec 1, 10:06 AM
Unknown Object (File)
Sat, Nov 30, 11:06 PM
Unknown Object (File)
Sat, Nov 30, 11:06 PM
Unknown Object (File)
Sat, Nov 30, 2:00 PM
Unknown Object (File)
Sat, Nov 30, 8:39 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9897: Unbeta Feedback on Phame
Commits
Restricted Diffusion Commit
rP74882503aaf9: Spiffy up PhamePostView
Summary

Cleaner Author information, less "Properties", Build a History Page. Ref T9897

Test Plan

Review New Posts, Draft Posts, View History

pasted_file (1×1 px, 217 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35460.Dec 3 2015, 11:22 PM
chad retitled this revision from to Spiffy up PhamePostView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9897: Unbeta Feedback on Phame.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 3 2015, 11:22 PM
chad edited the test plan for this revision. (Show Details)Dec 3 2015, 11:23 PM
epriestley accepted this revision.Dec 3 2015, 11:24 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/controller/post/PhamePostHistoryController.php
29–33

(I don't think this is possible in modern Phame?)

39

You can omit null if there's no href for very slight simplicity.

43–44

(Slightly extra indent?)

This revision is now accepted and ready to land.Dec 3 2015, 11:24 PM
chad added a comment.Dec 3 2015, 11:24 PM

I maybe could be talked into un-circling the profile photos, but I don't think people will take our blogging platform seriously without it.

epriestley added a comment.Dec 3 2015, 11:27 PM

I actually like them quite a bit, and I think it's nice that the UI has a little bit of a twist to it. It feels blog-like to me without feeling unfamiliar.

chad updated this revision to Diff 35461.Dec 3 2015, 11:28 PM
chad marked 3 inline comments as done.
chad edited edge metadata.
  • fix updates
Closed by commit rP74882503aaf9: Spiffy up PhamePostView (authored by chad, committed by chad). · Explain WhyDec 3 2015, 11:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
2 lines
applications/
phame/
application/
1 line
controller/
blog/
2 lines
post/
55 lines
68 lines
view/
2 lines
webroot/
rsrc/
css/
application/
phame/
5 lines

Diff 35462

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostHistoryController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phame/view/PhameDescriptionView.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
Phabricator · Built by Phacility