Ref T9132. This still has a lot of rough edges but the basics seem to work OK.
- Maniphest Tasks
- T9132: Build an ApplicationEditor abstraction
- Restricted Diffusion Commit
rPdc0d91413452: Basic stacked action support for EditEngine
This definitely needs some more work (drafts don't save the actions, for example, and I have no idea what it does on mobile but probably not anything great, and there are more than a few very rough patches in this code) but it at least mostly works, and I don't think it regresses or breaks anything -- it may just not work as well as it should in some cases.
I think this is the last major piece we need before I can at least try bringing this to Maniphest. Not sure how well that'll go, but hopefully not too bad.
(One other possible issue is "new similar task", not sure if I want to bring that into ApplicationEditor or not yet. I may just sort of hack around it for v0, although having "new similar object" in every application doesn't necessarily seem terrible to me, just also not clearly useful/desirable in many apps.)
Two possible issues with that:
- That might get hairy if we stick with the direct-status-actions in Differential ("Remove Accept Revision" next to "Request Changes"?). Not totally sure what that will look like yet.
- This interface will also be used in the EditEngine version of "Batch Editor", but it will have a "Remove Projects" action there, so we'd end up with "Remove 'Remove Projects' Action'" or similar.
I think we can get it working OK on mobile in the relatively short term through brute force and then refine this later once we have a clearer idea about other use cases.
The "use a dropdown to pick actions" UI feels a little odd to me, but I think I'll get used to it. It does seem a bit cleaner than the sort of Herald approach (where you select each action from a separate dropdown) in this situation (although I like the Herald approach for Herald).