Paths

Table of Contentst

Differential D14648

Update Ponder for Remarkup in Feed
ClosedPublic
Actions

Authored by chad on Dec 2 2015, 10:29 PM.

Tags

None

Referenced Files

	F13085561: D14648.diff
	Wed, Apr 24, 11:51 PM

	Unknown Object (File)
	Thu, Apr 11, 8:06 AM

	Unknown Object (File)
	Tue, Apr 9, 12:01 PM

	Unknown Object (File)
	Mar 16 2024, 1:20 AM

	Unknown Object (File)
	Mar 16 2024, 1:20 AM

	Unknown Object (File)
	Mar 7 2024, 3:58 AM

	Unknown Object (File)
	Mar 5 2024, 5:56 PM

	Unknown Object (File)
	Feb 23 2024, 9:55 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T9825: Remarkup is rendered literally in Diviner

Commits

Restricted Diffusion Commit
rP505ae7e26189: Update Ponder for Remarkup in Feed

Summary

Update Ponder Questions and Answers to render Remarkup in Feed

Test Plan

New Question, Edit Question, New Answer, Edit Answer, New Comment. See remarkup in Feed.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35433.Dec 2 2015, 10:29 PM

chad retitled this revision from to Update Ponder for Remarkup in Feed.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 2 2015, 10:29 PM

chad added a task: T9825: Remarkup is rendered literally in Diviner.Dec 2 2015, 10:30 PM

I think you still want/need getRemarkupBlocks(). Specifically, they make {F...} embeds (the files get attached properly) and @mentions and object references work properly. The rest of this looks good, I'm just pretty sure we want to keep those methods too.

A simple test case is to mention some T123 in a question/answer. Without these methods, I don't think it will generate a mention on T123. With these methods, it should.

This revision now requires changes to proceed.Dec 5 2015, 12:27 AM

update per feedback

epriestley accepted this revision.Dec 5 2015, 10:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2015, 10:32 PM

Closed by commit rP505ae7e26189: Update Ponder for Remarkup in Feed (authored by chad, committed by chad). · Explain WhyDec 5 2015, 10:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

storage/

PonderAnswerTransaction.php

16 lines

PonderQuestionTransaction.php

46 lines

Diff 35521

src/applications/ponder/storage/PonderAnswerTransaction.php

Loading...

src/applications/ponder/storage/PonderQuestionTransaction.php

Loading...