Page MenuHomePhabricator

Implement versioned drafts in EditEngine comment forms
ClosedPublic

Authored by epriestley on Dec 2 2015, 8:58 PM.
Tags
None
Referenced Files
F19081294: D14640.diff
Tue, Dec 2, 5:51 AM
F18850935: D14640.id.diff
Oct 30 2025, 8:41 PM
F18850807: D14640.id.diff
Oct 30 2025, 7:32 PM
F18844505: D14640.diff
Oct 29 2025, 5:51 AM
F18834212: D14640.id35446.diff
Oct 26 2025, 7:19 AM
F18658717: D14640.id.diff
Sep 23 2025, 8:02 AM
F18658701: D14640.id35418.diff
Sep 23 2025, 7:55 AM
F18593924: D14640.diff
Sep 12 2025, 4:27 PM
Subscribers
None

Details

Summary

Ref T9132. Fixes T5031. This approximately implements the plan described in T5031#67988:

When we recieve a preview request, don't write a draft if the form is from a version of the object before the last update the viewer made.

This should fix the race-related (?) zombie draft comments that sometimes show up.

I just added a new object for this stuff to make it easier to do stacked actions (or whatever we end up with) a little later, since I needed to do some schema adjustments anyway.

Test Plan
  • Typed some text.
  • Reloaded page.
  • Draft stayed there.
  • Tried real hard to get it to ghost by submitting stuff in multiple windows and typing a lot and couldn't, although I didn't bother specifically narrowing down the race condition.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable