Page MenuHomePhabricator

Implement versioned drafts in EditEngine comment forms
ClosedPublic

Authored by epriestley on Dec 2 2015, 8:58 PM.
Tags
None
Referenced Files
F15471053: D14640.id35446.diff
Sat, Apr 5, 3:01 AM
F15451120: D14640.id35418.diff
Fri, Mar 28, 8:14 PM
F15449208: D14640.id.diff
Fri, Mar 28, 8:53 AM
F15445849: D14640.id35446.diff
Thu, Mar 27, 4:13 PM
F15439460: D14640.diff
Wed, Mar 26, 7:37 AM
F15420446: D14640.id35446.diff
Fri, Mar 21, 2:04 PM
F15416368: D14640.id35446.diff
Thu, Mar 20, 10:43 AM
F15409748: D14640.id.diff
Wed, Mar 19, 5:05 AM
Subscribers
None

Details

Summary

Ref T9132. Fixes T5031. This approximately implements the plan described in T5031#67988:

When we recieve a preview request, don't write a draft if the form is from a version of the object before the last update the viewer made.

This should fix the race-related (?) zombie draft comments that sometimes show up.

I just added a new object for this stuff to make it easier to do stacked actions (or whatever we end up with) a little later, since I needed to do some schema adjustments anyway.

Test Plan
  • Typed some text.
  • Reloaded page.
  • Draft stayed there.
  • Tried real hard to get it to ghost by submitting stuff in multiple windows and typing a lot and couldn't, although I didn't bother specifically narrowing down the race condition.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable