Page MenuHomePhabricator

Initial support for comments/append-edits in EditEngine
ClosedPublic

Authored by epriestley on Dec 2 2015, 7:17 PM.
Tags
None
Referenced Files
F22534183: D14637.id35413.diff
Mon, Sep 21, 10:50 PM
F22511037: D14637.id35413.diff
Fri, Sep 18, 10:08 PM
Unknown Object (File)
Fri, Sep 4, 6:30 PM
Unknown Object (File)
Tue, Sep 1, 5:43 AM
Unknown Object (File)
Aug 26 2026, 10:18 PM
Unknown Object (File)
Aug 25 2026, 8:02 PM
Unknown Object (File)
Aug 23 2026, 12:51 PM
Unknown Object (File)
Aug 13 2026, 5:42 PM
Subscribers
None

Details

Summary

Ref T9132. This just replaces the "Add Comment" form in Paste with a generic flow in EditEngine.

No actual field-awareness or action stacking or anything quite yet, but that will come in a bit. This mildly regresses drafts (which don't seem like a big deal for Pastes). I'll hook those up again in the next diff, but I want to build them in a better way that will work with multiple actions in a generic way, and solve T5031.

Big practical advantage here is that applications don't need copy/pasted preview controllers.

Test Plan
  • Saw previews.
  • Added comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Initial support for comments/append-edits in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

Does this work for documents as well? I think Phame is our only commentable Document.

This revision is now accepted and ready to land.Dec 2 2015, 7:42 PM

Not yet, but it should by the time I get there.

This revision was automatically updated to reflect the committed changes.