Page MenuHomePhabricator

Initial support for comments/append-edits in EditEngine
ClosedPublic

Authored by epriestley on Dec 2 2015, 7:17 PM.
Tags
None
Referenced Files
F14043656: D14637.diff
Tue, Nov 12, 12:00 PM
F14027049: D14637.id35444.diff
Fri, Nov 8, 4:57 AM
F14027024: D14637.id35444.diff
Fri, Nov 8, 4:34 AM
F14027004: D14637.id.diff
Fri, Nov 8, 4:10 AM
F14026994: D14637.id35413.diff
Fri, Nov 8, 4:08 AM
F14026976: D14637.id35413.diff
Fri, Nov 8, 4:04 AM
F14026910: D14637.id.diff
Fri, Nov 8, 3:33 AM
F14011719: D14637.diff
Fri, Nov 1, 5:10 AM
Subscribers
None

Details

Summary

Ref T9132. This just replaces the "Add Comment" form in Paste with a generic flow in EditEngine.

No actual field-awareness or action stacking or anything quite yet, but that will come in a bit. This mildly regresses drafts (which don't seem like a big deal for Pastes). I'll hook those up again in the next diff, but I want to build them in a better way that will work with multiple actions in a generic way, and solve T5031.

Big practical advantage here is that applications don't need copy/pasted preview controllers.

Test Plan
  • Saw previews.
  • Added comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Initial support for comments/append-edits in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

Does this work for documents as well? I think Phame is our only commentable Document.

This revision is now accepted and ready to land.Dec 2 2015, 7:42 PM

Not yet, but it should by the time I get there.

This revision was automatically updated to reflect the committed changes.