Support HTTP parameter prefilling in EditEngine forms for CustomFields
ClosedPublic
Actions

Authored by epriestley on Dec 2 2015, 2:06 PM.

Details

Reviewers

chad

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction

Commits

Restricted Diffusion Commit
rPc1ae5321d745: Support HTTP parameter prefilling in EditEngine forms for CustomFields

Summary

Ref T9132. This allows you to prefill custom fields with ?custom.x.y=value, for most types of custom fields.

Dates (which are substantially more complicated) aren't supported. I'll just do those once the dust settles. Other types should work, I think.

Test Plan

Verified custom fields appear on "HTTP Parameters" help UI.
Used ?x=y to prefill custom fields on edit form.
Performed various normal edits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35404.Dec 2 2015, 2:06 PM

epriestley retitled this revision from to Support HTTP parameter prefilling in EditEngine forms for CustomFields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

This has a couple of small pieces of "weird glue" (with comments noting weirdness) but I think it's fairly sane overall.

It's hard to just move directly to a good state because I can't change CustomFields too much until everything uses EditEngine, since if I do other applications (Maniphest, Differential, etc) will break. So I'm trying to get us like 95% good, with as little "weird glue" as possible, and hopefully clean that up later.

chad accepted this revision.Dec 2 2015, 4:56 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2015, 4:56 PM

Closed by commit rPc1ae5321d745: Support HTTP parameter prefilling in EditEngine forms for CustomFields (authored by epriestley, committed by epriestley). · Explain WhyDec 2 2015, 5:32 PM

This revision was automatically updated to reflect the committed changes.