Page MenuHomePhabricator

Improve code structure of PHID fields in EditEngine
ClosedPublic

Authored by epriestley on Nov 29 2015, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 12:30 PM
Unknown Object (File)
Sat, Jan 18, 12:00 AM
Unknown Object (File)
Dec 18 2024, 11:30 AM
Unknown Object (File)
Dec 12 2024, 9:32 PM
Unknown Object (File)
Dec 8 2024, 10:08 PM
Unknown Object (File)
Nov 30 2024, 9:30 PM
Unknown Object (File)
Nov 11 2024, 8:03 AM
Unknown Object (File)
Nov 8 2024, 1:59 AM
Subscribers
None

Details

Summary

Ref T9132. I had some hacks in place for dealing with Edge/Subscribers stuff. Clean that up so it's structured a little better.

Test Plan
  • Edited subscribers and projects.
  • Verified things still show up in Conduit.
  • Made concurrent edits (added a project in one window, removed it in another window, got a clean result with a correct merge of the two edits).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve code structure of PHID fields in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 3:00 PM
This revision was automatically updated to reflect the committed changes.