Page MenuHomePhabricator
Differential D14575

Pass recently applied transactions to HeraldAdapters
ClosedPublic
Actions

Authored by epriestley on Nov 26 2015, 2:58 PM.

Details

Reviewers
chad
Maniphest Tasks
T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events
Commits
Restricted Diffusion Commit
rPfc1c36106daf: Pass recently applied transactions to HeraldAdapters
Summary

Ref T9851. See T9860. This adds a missing capability to custom HeraldActions, to pave the way for removing the obsolete/undesirable WILLEDITTASK and DIDEDITTASK events.

Test Plan

See T9860 for a replacement action.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 35266.Nov 26 2015, 2:58 PM
epriestley retitled this revision from to Pass recently applied transactions to HeraldAdapters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.
chad accepted this revision.Nov 26 2015, 4:31 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 26 2015, 4:31 PM
Closed by commit rPfc1c36106daf: Pass recently applied transactions to HeraldAdapters (authored by epriestley). · Explain WhyNov 26 2015, 4:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35268

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility