Differential D14575

Pass recently applied transactions to HeraldAdapters
ClosedPublic
Actions

Authored by epriestley on Nov 26 2015, 2:58 PM.

Details

Reviewers

chad

Maniphest Tasks

T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events

Commits

Restricted Diffusion Commit
rPfc1c36106daf: Pass recently applied transactions to HeraldAdapters

Summary

Ref T9851. See T9860. This adds a missing capability to custom HeraldActions, to pave the way for removing the obsolete/undesirable WILLEDITTASK and DIDEDITTASK events.

Test Plan

See T9860 for a replacement action.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 35266.Nov 26 2015, 2:58 PM

epriestley retitled this revision from to Pass recently applied transactions to HeraldAdapters.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

epriestley mentioned this in T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.Nov 26 2015, 3:27 PM

chad accepted this revision.Nov 26 2015, 4:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 26 2015, 4:31 PM

Closed by commit rPfc1c36106daf: Pass recently applied transactions to HeraldAdapters (authored by epriestley). · Explain WhyNov 26 2015, 4:53 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13283: When Herald acts, include the transaction group as part of the "state" it acts upon.May 13 2019, 4:56 PM

epriestley mentioned this in D20518: In Herald, save applied transaction PHIDs in the transcript and display them in the UI.May 13 2019, 5:02 PM

epriestley mentioned this in rP046888ac2e56: In Herald, save applied transaction PHIDs in the transcript and display them in….May 16 2019, 4:58 PM

Revision Contents
Changeset List

			Path	Packages
M			src/applications/herald/adapter/HeraldAdapter.php (31 lines)
M			src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35266	b219285		Nov 26 2015, 2:58 PM	★	★
Diff 2	35268	8c016b2	Commit rPfc1c36106daf8e4f0c5866ce6e80c3c6015c43ca	Nov 26 2015, 4:53 PM	★	★

Diff 35268

View Options

src/applications/herald/adapter/HeraldAdapter.php