Add rule to lint for PSR2 spec spacing after use statements.
AbandonedPublic
Actions

Authored by lucaspickup on Nov 22 2015, 10:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 7:02 AM

	Unknown Object (File)
	Nov 27 2024, 9:22 PM

	Unknown Object (File)
	Nov 27 2024, 7:28 AM

	Unknown Object (File)
	Nov 26 2024, 1:24 AM

	Unknown Object (File)
	Nov 20 2024, 9:26 AM

	Unknown Object (File)
	Nov 15 2024, 9:51 PM

	Unknown Object (File)
	Nov 12 2024, 5:08 AM

	Unknown Object (File)
	Nov 8 2024, 7:49 AM

View All 78 Files

Subscribers

epriestley

This revision can not be accepted until the required legal agreements have been signed.

Details

Reviewers

josh

Group Reviewers

Blessed Reviewers

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

This rule detects when there is no blank newline after a signle or series of use statement.
This blank line is required under the PSR-2 Spec, 3.0.
Ref T20874

Test Plan

There are unti tests included and I tried the rule a few times in gaf on some modfied files.

Diff Detail

Repository

rARC Arcanist

Branch

newline-use-psr2

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8981
Build 10545: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	422 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	119 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	663 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	120 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	52 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 37 Passed · 19 Skipped)

Event Timeline

lucaspickup updated this revision to Diff 35170.Nov 22 2015, 10:33 PM

lucaspickup retitled this revision from to Add rule to lint for PSR2 spec spacing after use statements..

lucaspickup updated this object.

lucaspickup edited the test plan for this revision. (Show Details)

lucaspickup added a reviewer: josh.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 22 2015, 10:33 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

Forgot to set the conduit URI....

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.