Page MenuHomePhabricator
Differential D14527

Add mask-icon for Safari pinned tab
ClosedPublic
Actions

Authored by puls on Nov 20 2015, 2:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 5:51 AM
Unknown Object (File)
Mon, Dec 9, 5:46 AM
Unknown Object (File)
Sun, Dec 8, 2:57 AM
Unknown Object (File)
Mon, Dec 2, 2:51 PM
Unknown Object (File)
Tue, Nov 19, 12:08 PM
Unknown Object (File)
Nov 11 2024, 1:47 PM
Unknown Object (File)
Nov 11 2024, 6:15 AM
Unknown Object (File)
Nov 9 2024, 10:44 AM
View All Files
Subscribers
chad
Korvin
Tokens
"Love" token, awarded by rodbegbie.

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9814: Add SVG icon for Safari 9's pinned tabs
Commits
Restricted Diffusion Commit
rP9001d5de2cba: Add mask-icon for Safari pinned tab
Summary

Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that
I made by pulling the existing favicon into Illustrator and running trace on it.

This hardcodes the header color from the default theme, and doesn't pay attention
to customizations of the header.

Test Plan

I pinned the tab in Safari.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

puls updated this revision to Diff 35141.Nov 20 2015, 2:51 AM
puls retitled this revision from to Add mask-icon for Safari pinned tab.
puls updated this object.
puls edited the test plan for this revision. (Show Details)
puls added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 20 2015, 2:51 AM
Herald added a subscriber: Korvin. · View Herald Transcript
puls added a task: T9814: Add SVG icon for Safari 9's pinned tabs.Nov 20 2015, 2:52 AM
puls updated this revision to Diff 35142.Nov 20 2015, 3:33 AM
puls edited edge metadata.

Fixed line wrapping.

chad added a subscriber: chad.Nov 20 2015, 4:49 AM

wat

rodbegbie awarded a token.Nov 21 2015, 2:18 AM
chad accepted this revision.Nov 22 2015, 5:32 PM
chad added a reviewer: chad.

Tested this and works fine for me, up to @epriestley to verify and land.

This revision is now accepted and ready to land.Nov 22 2015, 5:32 PM
Closed by commit rP9001d5de2cba: Add mask-icon for Safari pinned tab (authored by puls, committed by epriestley). · Explain WhyNov 22 2015, 9:04 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9814: Add SVG icon for Safari 9's pinned tabs.Nov 22 2015, 10:04 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
27 lines
src/
applications/
celerity/
controller/
1 line
resources/
1 line
view/
page/
13 lines
webroot/
rsrc/
favicons/
20 lines

Diff 35164

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/controller/CelerityResourceController.php

Loading...
View Options

src/applications/celerity/resources/CelerityResourcesOnDisk.php

Loading...
View Options

src/view/page/PhabricatorBarePageView.php

Loading...
View Options

webroot/rsrc/favicons/mask-icon.svg

Loading...
Phabricator · Built by Phacility