Page MenuHomePhabricator
Differential D14456

Always override `auth.email-domains` when running unit tests
ClosedPublic
Actions

Authored by lpriestley on Nov 10 2015, 6:11 PM.
Tags
None
Referenced Files
F18150387: D14456.id.diff
Thu, Aug 14, 6:08 PM
F18114653: D14456.diff
Wed, Aug 13, 5:13 AM
F18103046: D14456.diff
Sun, Aug 10, 1:20 AM
F18085307: D14456.diff
Tue, Aug 5, 7:08 PM
F17943978: D14456.id34950.diff
Thu, Jul 31, 9:09 AM
Unknown Object (File)
Jun 6 2025, 8:29 PM
Unknown Object (File)
Jun 4 2025, 5:18 AM
Unknown Object (File)
Apr 26 2025, 11:57 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9689: unit test failure when auth.email-domains is configured
Commits
Restricted Diffusion Commit
rP64ad44cffb24: Always override `auth.email-domains` when running unit tests
Summary

Fixes T9689, Always override auth.email-domains when running unit tests

Test Plan
  • Set auth.email-domains
  • Run arc unit --everything.

Observe no errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 34950.Nov 10 2015, 6:11 PM
lpriestley retitled this revision from to Always override `auth.email-domains` when running unit tests.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T9689: unit test failure when auth.email-domains is configured.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 10 2015, 6:11 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 10 2015, 6:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 6:12 PM
Closed by commit rP64ad44cffb24: Always override `auth.email-domains` when running unit tests (authored by lpriestley, committed by lpriestley). · Explain WhyNov 10 2015, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
__tests__/
1 line
infrastructure/
testing/
4 lines

Diff 34951

View Options

src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php

Loading...
View Options

src/infrastructure/testing/PhabricatorTestCase.php

Loading...
Phabricator · Built by Phacility