Page MenuHomePhabricator

Allow ApplicationEditor forms to be reconfigured
ClosedPublic

Authored by epriestley on Nov 10 2015, 2:17 PM.
Tags
None
Referenced Files
F13192457: D14453.id34942.diff
Sun, May 12, 7:43 AM
F13190399: D14453.id34953.diff
Sat, May 11, 10:41 AM
F13177878: D14453.diff
Wed, May 8, 8:01 PM
Unknown Object (File)
Sat, May 4, 7:09 PM
Unknown Object (File)
Fri, May 3, 4:13 PM
Unknown Object (File)
Thu, Apr 25, 12:55 AM
Unknown Object (File)
Apr 6 2024, 8:44 PM
Unknown Object (File)
Mar 7 2024, 4:55 PM
Subscribers
None

Details

Summary

Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.

Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:

  • "New Bug Report"
  • "New Feature Request"

These would be views of the "Create Task" form, but with various adjustments:

  • A form might have additional instructions ("how to file a good bug report").
  • A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
  • A form might have some fields locked (so they can not be edited) or hidden.
  • A form might have a different field order.
  • A form might have a limited visibility policy, so only some users can access it.

This diff adds a new storage object (EditEngineConfiguration) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".

This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.

Test Plan

ApplicationEditor forms now let you manage available forms and edit the current form:

Screen Shot 2015-11-10 at 6.13.11 AM.png (166×301 px, 16 KB)

There's a new (bare bones) list of all available engines:

Screen Shot 2015-11-10 at 6.13.57 AM.png (858×1 px, 114 KB)

And if you jump into an engine, you can see all the forms for it:

Screen Shot 2015-11-10 at 6.15.10 AM.png (713×1 px, 117 KB)

The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow ApplicationEditor forms to be reconfigured.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 4:15 PM
This revision was automatically updated to reflect the committed changes.