Page MenuHomePhabricator

Add comments to internal Phame Posts
ClosedPublic

Authored by chad on Nov 10 2015, 5:25 AM.
Tags
None
Referenced Files
F14029340: D14451.id34943.diff
Fri, Nov 8, 8:27 PM
F14029339: D14451.id34936.diff
Fri, Nov 8, 8:27 PM
F14029338: D14451.id.diff
Fri, Nov 8, 8:27 PM
F14029337: D14451.diff
Fri, Nov 8, 8:27 PM
F14001057: D14451.id34943.diff
Fri, Oct 25, 3:48 AM
F13987297: D14451.id34936.diff
Mon, Oct 21, 8:37 AM
F13987112: D14451.diff
Mon, Oct 21, 7:32 AM
Unknown Object (File)
Oct 2 2024, 2:22 AM
Subscribers

Details

Summary

Adds commenting to Phame Posts, also testing a new "document comment style". Unsure about it but Phame is a prototype so good place to explore.

Test Plan

Leave some comments, see some comments, test show/hide.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add comments to internal Phame Posts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/controller/post/PhamePostViewController.php
86–87

Thinking about this, do we really even need to impose this restriction, given that stuff is internal-facing and we have other stuff like "subscribing to the blog subscribes to posts"? Maybe just leave it off for now until we find that the timeline is too spammy in practice and can't clean it up in other ways?

This revision is now accepted and ready to land.Nov 10 2015, 10:02 AM

I don't disagree on fundamentals, but it changes my work from being "design a commenting tool" to "redesign timeline". It might be I still end up at the same place, but right now I want to explore the first one a bit more.

This revision was automatically updated to reflect the committed changes.