Provide a more informative alternative to 404 on invalid shortened Phurl URL
ClosedPublic
Actions

Authored by lpriestley on Nov 9 2015, 10:37 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP2b5bb642c075: Provide a more informative alternative to 404 on invalid shortened Phurl URL

Summary

When accessing an invalid URL on the short Phurl domain, users should see informative message

Test Plan

Open URL in the previously configured Phurl short domain such as https://www.zz.us and see dialog with message. Open https://www.zz.us/u/123 for a valid U123 Phurl and access destination URL.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 34931.Nov 9 2015, 10:37 PM

lpriestley retitled this revision from to Provide a more informative alternative to 404 on invalid shortened Phurl URL.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 9 2015, 10:37 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Very minor, but we should probably set the HTTP response code to 404 on these. You should be able to do something like this:

$dialog = $this->newDialog()
  ->...

return id(new AphrontDialogResponse())
  ->setDialog($dialog)
  ->setResponseCode(404);

This revision is now accepted and ready to land.Nov 9 2015, 10:40 PM

Setting http response code on 'invalid url' dialog

Closed by commit rP2b5bb642c075: Provide a more informative alternative to 404 on invalid shortened Phurl URL (authored by lpriestley, committed by lpriestley). · Explain WhyNov 10 2015, 4:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

controller/

PhabricatorPhurlShortURLDefaultController.php

12 lines

Diff 34945

View Options

src/applications/phurl/controller/PhabricatorPhurlShortURLDefaultController.php

Provide a more informative alternative to 404 on invalid shortened Phurl URLClosedPublicActions