Page MenuHomePhabricator

Add mail support to PhameBlog
ClosedPublic

Authored by chad on Nov 7 2015, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 12:18 AM
Unknown Object (File)
Thu, Mar 7, 8:35 AM
Unknown Object (File)
Tue, Mar 5, 2:44 AM
Unknown Object (File)
Tue, Mar 5, 2:44 AM
Unknown Object (File)
Tue, Mar 5, 2:44 AM
Unknown Object (File)
Tue, Mar 5, 2:44 AM
Unknown Object (File)
Tue, Mar 5, 2:44 AM
Unknown Object (File)
Mon, Feb 26, 2:33 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPc3ecea9788c1: Add mail support to PhameBlog
Summary

Add some mailkeys, allow feed stories to be published.

Test Plan

New Blog, Edit Blog

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add mail support to PhameBlog.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
  • correct subscribers spelling

Sadly have not gotten this to work. Error is as follows, but I can't find a reason for it to trigger.

Unable to load query for transaction type "BLOG"! at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:133]

That error likely means you need to add a new PhameBlogTransactionQuery class. You can look at PhamePostTransactionQuery for an example -- it's pretty straightforward.

epriestley edited edge metadata.

Rest of this looks fine to me.

This revision now requires changes to proceed.Nov 8 2015, 2:25 PM
chad edited edge metadata.
  • correct subscribers spelling
  • Fix remaining mail/feed bugs
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2015, 4:09 PM
This revision was automatically updated to reflect the committed changes.