Paths

Table of Contentst

Differential D14397

PHUIDocumentViewPro tweaks
ClosedPublic
Actions

Authored by chad on Nov 3 2015, 9:35 PM.

Tags

None

Referenced Files

	F14474995: D14397.id34781.diff
	Fri, Dec 27, 5:27 PM

	Unknown Object (File)
	Thu, Dec 12, 6:34 AM

	Unknown Object (File)
	Thu, Dec 12, 6:06 AM

	Unknown Object (File)
	Sun, Dec 8, 4:06 PM

	Unknown Object (File)
	Nov 27 2024, 6:31 AM

	Unknown Object (File)
	Nov 27 2024, 4:45 AM

	Unknown Object (File)
	Nov 27 2024, 3:50 AM

	Unknown Object (File)
	Nov 23 2024, 11:30 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP39f8feab5aa9: PHUIDocumentViewPro tweaks

Summary

Use in MailCommands and HTTP Parameters

Test Plan

Tested MailCommands in Paste, HTTP Parameters in Paste, Legalpad, Diviner. Mobile and Desktop breakpoints.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34781.Nov 3 2015, 9:35 PM

chad retitled this revision from to PHUIDocumentViewPro tweaks.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 3 2015, 9:35 PM

epriestley accepted this revision.Nov 3 2015, 9:36 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/transactions/editengine/PhabricatorApplicationEditEngine.php
380–381	Nuke this now?
src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php
308–315	We (probably?) don't need the boxes anymore and this could just be `$intro, $main_table, ...` and remove renderTable() + renderInstructions() I think?

This revision is now accepted and ready to land.Nov 3 2015, 9:36 PM

updates

Closed by commit rP39f8feab5aa9: PHUIDocumentViewPro tweaks (authored by chad, committed by chad). · Explain WhyNov 3 2015, 9:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

applications/

meta/

controller/

PhabricatorApplicationEmailCommandsController.php

4 lines

transactions/

editengine/

PhabricatorApplicationEditEngine.php

6 lines

view/

PhabricatorApplicationEditHTTPParameterHelpView.php

22 lines

webroot/

rsrc/

css/

phui/

phui-document-pro.css

5 lines

phui-info-view.css

4 lines

Diff 34783

resources/celerity/map.php

Loading...

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php

Loading...

src/applications/transactions/editengine/PhabricatorApplicationEditEngine.php

Loading...

src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php

Loading...

webroot/rsrc/css/phui/phui-document-pro.css

Loading...

webroot/rsrc/css/phui/phui-info-view.css

Loading...