Paths

Table of Contentst

Differential D14392

Provide contextual documentation explaining how to prefill ApplicationEditor create forms
ClosedPublic
Actions

Authored by epriestley on Nov 3 2015, 2:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 8:04 AM

	Unknown Object (File)
	Tue, Apr 9, 6:03 PM

	Unknown Object (File)
	Tue, Apr 9, 8:45 AM

	Unknown Object (File)
	Sat, Apr 6, 5:51 PM

	Unknown Object (File)
	Sat, Apr 6, 6:09 AM

	Unknown Object (File)
	Mon, Apr 1, 3:07 PM

	Unknown Object (File)
	Sat, Mar 30, 6:20 AM

	Unknown Object (File)
	Thu, Mar 28, 2:52 PM

Subscribers

None

Tokens

"Like" token, awarded by ftdysa.

Details

Reviewers

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction

Commits

Restricted Diffusion Commit
rP3dec4c7dbdd2: Provide contextual documentation explaining how to prefill ApplicationEditor…

Summary

Ref T9132. Although forms do generally support prefilling right now, you have to guess how to do it.

Provide an explicit action showing you which values are supported and how to prefill them. This is generated automatically when an application switches to ApplicationEditor.

Test Plan

Screen Shot 2015-11-03 at 6.34.19 AM.png (885×1 px, 114 KB)

Screen Shot 2015-11-03 at 6.34.03 AM.png (1×1 px, 333 KB)

Screen Shot 2015-11-03 at 6.34.06 AM.png (1×1 px, 223 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34766.Nov 3 2015, 2:41 PM

epriestley retitled this revision from to Provide contextual documentation explaining how to prefill ApplicationEditor create forms.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

Herald edited edge metadata. · View Herald TranscriptNov 3 2015, 2:41 PM

Minor wordsmithing.

Herald edited edge metadata. · View Herald TranscriptNov 3 2015, 2:44 PM

Oh, and I didn't use the "Pro" version here since it looked like it's not quite ready (by default, at least, the margins/padding/spacing/sizes all seemed a bit whack), but let me know if I just missed something.

It should just work by this point (I have some mobile stuff to clean up), but I can look at it after you land. Maybe table issues?

This revision is now accepted and ready to land.Nov 3 2015, 3:27 PM

ftdysa awarded a token.Nov 3 2015, 4:22 PM

Closed by commit rP3dec4c7dbdd2: Provide contextual documentation explaining how to prefill ApplicationEditor… (authored by epriestley, committed by epriestley). · Explain WhyNov 3 2015, 6:12 PM

This revision was automatically updated to reflect the committed changes.

how do i... set a class on newPage()

It's just a PhabricatorStandardPageView so you can addClass() it.

tumblr_inline_ns01nn11wv1rucu67_540.jpg (360×408 px, 19 KB)

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

__phutil_library_map__.php

2 lines

applications/

base/

PhabricatorApplication.php

4 lines

paste/

application/

PhabricatorPasteApplication.php

2 lines

controller/

PhabricatorPasteListController.php

2 lines

editor/

PhabricatorPasteEditEngine.php

8 lines

transactions/

editengine/

PhabricatorApplicationEditEngine.php

169 lines

editfield/

PhabricatorEditField.php

14 lines

PhabricatorPolicyEditField.php

4 lines

PhabricatorSelectEditField.php

4 lines

PhabricatorSpaceEditField.php

4 lines

PhabricatorTokenizerEditField.php

4 lines

view/

PhabricatorApplicationEditHTTPParameterHelpView.php

336 lines

webroot/

rsrc/

css/

aphront/

4 lines

Diff 34773

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/base/PhabricatorApplication.php

Loading...

src/applications/paste/application/PhabricatorPasteApplication.php

Loading...

src/applications/paste/controller/PhabricatorPasteListController.php

Loading...

src/applications/paste/editor/PhabricatorPasteEditEngine.php

Loading...

src/applications/transactions/editengine/PhabricatorApplicationEditEngine.php

Loading...

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorPolicyEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorSelectEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorSpaceEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorTokenizerEditField.php

Loading...

src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php

Loading...

webroot/rsrc/css/aphront/table-view.css

Loading...