Page MenuHomePhabricator
Differential D14278

Preserve "Space" UI control value when editing Passphrase credentials
ClosedPublic
Actions

Authored by epriestley on Oct 14 2015, 2:51 PM.
Tags
None
Referenced Files
F19454755: D14278.id34467.diff
Dec 31 2025, 2:41 AM
F19454754: D14278.id34466.diff
Dec 31 2025, 2:41 AM
F19454752: D14278.id.diff
Dec 31 2025, 2:41 AM
F19060677: D14278.diff
Nov 29 2025, 10:04 AM
F19060242: D14278.diff
Nov 29 2025, 8:51 AM
F18851350: D14278.id.diff
Oct 31 2025, 12:12 AM
F18845016: D14278.diff
Oct 29 2025, 9:06 AM
F18840182: D14278.id.diff
Oct 27 2025, 10:13 PM
View All Files
Subscribers
revi

Details

Reviewers
chad
Maniphest Tasks
T9568: Passphrase credentials do not preserve "Space" when edited
Commits
Restricted Diffusion Commit
rP3a91e648975c: Preserve "Space" UI control value when editing Passphrase credentials
Summary

Fixes T9568. We just weren't setting this properly so it would default away from the proper value.

Test Plan
  • Edited a credential in a non-default space, edit form populated properly.
  • Changed "Space", introduced an error, saved form, got error with sticky value for "Space" properly.
  • Saved form with new space value.
  • Created a new credential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34466.Oct 14 2015, 2:51 PM
epriestley retitled this revision from to Preserve "Space" UI control value when editing Passphrase credentials.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9568: Passphrase credentials do not preserve "Space" when edited.
revi added a subscriber: revi.Oct 14 2015, 3:02 PM
chad accepted this revision.Oct 14 2015, 3:12 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 14 2015, 3:12 PM
Closed by commit rP3a91e648975c: Preserve "Space" UI control value when editing Passphrase credentials (authored by epriestley, committed by epriestley). · Explain WhyOct 14 2015, 3:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
passphrase/
controller/
1 line

Diff 34467

View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

Loading...
Phabricator · Built by Phacility