Page MenuHomePhabricator

Preserve "Space" UI control value when editing Passphrase credentials
ClosedPublic

Authored by epriestley on Oct 14 2015, 2:51 PM.
Tags
None
Referenced Files
F14054893: D14278.diff
Sat, Nov 16, 6:13 AM
F14043927: D14278.diff
Tue, Nov 12, 2:00 PM
F14028245: D14278.id34467.diff
Fri, Nov 8, 12:40 PM
F14028244: D14278.id34466.diff
Fri, Nov 8, 12:40 PM
F14028243: D14278.id.diff
Fri, Nov 8, 12:40 PM
F14028241: D14278.diff
Fri, Nov 8, 12:40 PM
F14027561: D14278.diff
Fri, Nov 8, 7:55 AM
F14010920: D14278.id34467.diff
Thu, Oct 31, 1:33 PM
Subscribers

Details

Summary

Fixes T9568. We just weren't setting this properly so it would default away from the proper value.

Test Plan
  • Edited a credential in a non-default space, edit form populated properly.
  • Changed "Space", introduced an error, saved form, got error with sticky value for "Space" properly.
  • Saved form with new space value.
  • Created a new credential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Preserve "Space" UI control value when editing Passphrase credentials.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 14 2015, 3:12 PM
This revision was automatically updated to reflect the committed changes.