Page MenuHomePhabricator
Differential D14275

Allow API tokens to be added to arcrc
AbandonedPublic
Actions

Authored by cinek on Oct 14 2015, 12:40 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:02 PM
Unknown Object (File)
Fri, Nov 15, 11:42 PM
Unknown Object (File)
Tue, Nov 12, 1:42 PM
Unknown Object (File)
Fri, Nov 8, 12:39 PM
Unknown Object (File)
Fri, Nov 8, 12:39 PM
Unknown Object (File)
Fri, Nov 8, 12:39 PM
Unknown Object (File)
Fri, Nov 8, 4:57 AM
Unknown Object (File)
Oct 13 2024, 10:18 PM
View All Files
Subscribers
Korvin

Details

Reviewers
hach-que
epriestley
hofan41
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8143: Allow creation of Conduit API Tokens for bots
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

When generating conduit tokens for bot users, one gets an API token with prefix
"api-". With this trivial fix arc install-certificate allows such tokens to
be set up in ~/.arcrc.

This commit fixes T8143.

Test Plan
  • Started arc install-certificate.
  • Generated API token at https://phabricator.domain.org/settings/panel/apitokens/.
  • Pasted API token to arc prompt.
  • Verified that API token showed up in ~/.arcrc.

Diff Detail

Repository
rARC Arcanist
Branch
fixT8143
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8274
Build 9477: arc lint + arc unit

Event Timeline

cinek updated this revision to Diff 34457.Oct 14 2015, 12:40 PM
cinek retitled this revision from to Allow API tokens to be added to arcrc.
cinek updated this object.
cinek edited the test plan for this revision. (Show Details)
cinek added a reviewer: epriestley.
cinek added a task: T8143: Allow creation of Conduit API Tokens for bots.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 14 2015, 12:40 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: Korvin. · View Herald Transcript
cinek added reviewers: hach-que, hofan41.Oct 18 2015, 8:31 PM
cinek added projects: Arcanist, Conduit.
epriestley requested changes to this revision.Nov 2 2015, 4:42 PM
epriestley edited edge metadata.

It's intentional that you can't add api- tokens via this workflow. Use --conduit-token. I don't intend to bring this change or any similar change upstream.

This revision now requires changes to proceed.Nov 2 2015, 4:42 PM
cinek abandoned this revision.Nov 2 2015, 5:51 PM

It's OK. I can still add the API tokens for bots manually to the configuration. I don't like users to see them in ps output.

Revision Contents
Changeset List

PathSize
src/
workflow/
16 lines

Diff 34457

View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
Phabricator · Built by Phacility